[FFmpeg-devel] [PATCH] Fix PSX MDEC decoder

[Reimar Döffinger]

On 2 jan 2011, at 12:18, Vitor Sessak <vitor1001 at gmail.com> wrote:
> On 01/02/2011 04:43 AM, Michael Niedermayer wrote:
>> On Sat, Jan 01, 2011 at 07:52:38PM +0100, Vitor Sessak wrote:
>>> Hi,
>>> 
>>> I saw in a blog post [1] that FFmpeg decodes Playstation 1 video files
>>> with artifacts. It is indeed true, due to a wrong pixfmt (YUV/YUVJ) and
>>> not imposing using DCT_SIMPLE, as is done in MPEG1. The attached patch
>>> fixes it.
>>> 
>>> For reference, I'm attaching a decoded frame with:
>>> 
>>> 1- Current SVN with -idct mmx
>>> 2- Current SVN with -idct simple
>>> 3- Patched SVN
>>> 4- Reference decoder output (i.e., PS1 image grab)
>>> 
>>> -Vitor
>>> 
>>> [1]
>>> http://jpsxdec.blogspot.com/2010/09/psx-video-decoders-final-showdown.html
>>> 
>> 
>>>  mdec.c |    4 +++-
>>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>> 5c901ccdc3ae44b4a0fc43246c15ee462603a563  fix_mdec.diff
>> 
>> if this fixes a bug, ok of course
>> dont forget testing /updating fate
> 
> Applied. FATE didn't need to get updated since it uses already "-idct simple".

Maybe you should remove that then for that test? Or is that option part of the test framework? Would still be possible to add an explicit -idct auto for that, but maybe that's overkill.
>