[FFmpeg-devel] [PATCH] fix for roundup issue 2127

[Michael Niedermayer]

On Sat, Jan 01, 2011 at 02:33:04PM -0500, Daniel Kang wrote:
> On Sat, Jan 1, 2011 at 2:21 PM, Reimar D?ffinger
> <Reimar.Doeffinger at gmx.de>wrote:
> >
> > I understand that you need to change the type of the function parameters,
> > but if you also need to cast the function arguments where the function is
> > called that would be such a gigantic compiler bug I can't imagine that is
> > really the case.
> > Also at least for gcc you can just cast the variables in the constraints,
> > but I think clang or lock have issues with that...
> 
> 
> I'm not sure what you mean by "such a gigantic compiler bug". All the
> bugs are the same, which is essentially mixing 32- and 64-bit registers
> for addressing is illegal. Maybe I didn't clarify how I got the compiler
> messages. If the transpose4x4 function arguments are changed back "int"
> and there is no casting in the call, then the errors are generated.
> 

> I added the casts because I thought it is clearer this way. Removing the
> casts but keeping the transpose4x4 function arguments the same does not
> give the errors. Should I do this instead?

yes


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110102/a9e18701/attachment.pgp>