[FFmpeg-devel] [PATCH] Add drawtext filter from the libavfilter soc repo.

[Måns Rullgård]

Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:

> On date Tuesday 2011-02-22 01:59:04 +0100, Michael Niedermayer encoded:
>> On Mon, Feb 21, 2011 at 01:02:29AM +0100, Stefano Sabatini wrote:
>> > On date Sunday 2011-02-20 23:44:46 +0100, Stefano Sabatini encoded:
>> > > On date Sunday 2011-02-20 00:10:17 +0100, Stefano Sabatini encoded:
>> > > > On date Saturday 2011-02-19 15:21:13 +0000, M?ns Rullg?rd encoded:
>> > > [...]
>> > > > > You might want to do something clever with the tab character.  I don't
>> > > > > really have a good suggestion though.
>> > > > 
>> > > > Skipped for now, we could add an option for setting the tab size.
>> > > > 
>> > > > Other changes: I *removed* the code for rendering the font outline,
>> > > > the result was honestly rather poor, this also allowed to make more
>> > > > clear the interface (fgcolor -> fontcolor, bgcolor -> boxcolor).
>> > > > 
>> > > > Again on the interface side, I wonder if it is a good idea to keep the
>> > > > ftload flags, the only useful flag which I can discern amongst the
>> > > > many flags is +monochrome, but it may be enabled with monochrome=1 in
>> > > > the options string.
>> > > > Comments?
>> > > > 
>> > > > Still missing: docs update and RGB support, it should not be too
>> > > > complicate to add it (but I can eventually do it as a separate patch).
>> > > 
>> > > Updated, patch depends on the drawutils patch.
>> > > Added RGB path and tabsize option, documentation updated accordingly.
>> > > 
>> > > Ad for the ft_load_flags, I decided for keeping them, comments on this
>> > > are welcome.
>> > 
>> > Fixed a leak (in uninit).
>> > -- 
>> > FFmpeg = Foolish Freak Minimal Powerful Elfic Gadget
>> 
>> >  configure                 |    6 
>> >  doc/filters.texi          |  112 +++++++
>> >  libavfilter/Makefile      |    1 
>> >  libavfilter/allfilters.c  |    1 
>> >  libavfilter/vf_drawtext.c |  650 ++++++++++++++++++++++++++++++++++++++++++++++
>> >  5 files changed, 770 insertions(+)
>> > a9420cd521b46226cc84e5db66f5d58d4161524d  0003-lavfi-add-drawtext-filter.patch
>> > From 9ad722861896bd58b4304a4fbb1df83eabf97dfe Mon Sep 17 00:00:00 2001
>> > From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
>> > Date: Tue, 28 Sep 2010 16:09:27 +0200
>> > Subject: [PATCH] lavfi: add drawtext filter
>> 
>> commited with various bugfixes and improvments
>
> Ping, does someone care to apply to the ffmpeg at ffmpeg repo? (Don't
> forget minor bump and a Changelog entry which I missed.)

I haven't had time to review it yet.  Is the last one you posted ready
for final review?

-- 
M?ns Rullg?rd
mans at mansr.com