[FFmpeg-devel] [PATCH] Remove old VCSs from version.sh

Alex Converse alex.converse
Mon Feb 21 11:33:24 CET 2011


On Mon, Feb 21, 2011 at 2:17 AM, Alex Converse <alex.converse at gmail.com> wrote:
> On Mon, Feb 21, 2011 at 2:09 AM, Reinhard Tartler <siretart at tauware.de> wrote:
>> On Mon, Feb 21, 2011 at 11:05:24 (CET), Alex Converse wrote:
>>
>>> Can you give an example of where this snapshot_version is currently used?
>>
>> In 'my' packaging for debian.
>>
>>> The original documentation for snapshot_version says:
>>>
>>> Read revision string from the file snapshot_version if available.
>>> This will be used by daily snapshots without Subversion metadata.
>>>
>>> It is in the group of revision probes that get prefixed with SVN-r
>>> which implies that if it is still used it is at best wrong.
>>
>> Seems largely correct, but of course needs to be reworded to be
>> SVN-agnostic. It is basically needed to override foreign, bad, or
>> missing VCS information.
>>
>
> Don't we already have a VERSION file for when there is no VCS info?
>

On further inspection, I don't care. Attached is an updated patch;
snapshot_version remains as-is.

Anyone who wants to come up with a modern interpretation or
replacement of this snapshot_version file is welcome to do so after
this has landed. After all, none of the snapshot_version defenders
seemed to care about it making sense until I tried to remove it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-old-VCSs-from-version.sh.patch
Type: text/x-patch
Size: 1662 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110221/718a99dc/attachment.bin>



More information about the ffmpeg-devel mailing list