[FFmpeg-devel] [PATCH] avio API cleanup II

Anton Khirnov anton
Sat Feb 19 19:46:46 CET 2011 

On Sat, Feb 19, 2011 at 04:01:22PM +0100, Michael Niedermayer wrote:
> On Sat, Feb 19, 2011 at 12:42:44PM +0100, Anton Khirnov wrote:
> > Hi,
> > due to BBB being lazy, here's the updated batch of renames.
> > 
> > The basic idea is that functions working on AVIOContext (formerly
> > ByteIOContext) get an avio_ prefix, while functions working on
> > URLContext (to be renamed to AVURLContext) get an av_url_ prefix.
> > 
> > Comments welcome.
> 
> You are making hundreads of internal functions part of the public API
> The correct prefix is ff not av for quite a few i think
> That said if you make things part of the public API have you thought about
> the structs being ready for this? Can they be extended without breaking ABI?

They aren't internal, being in an installed header makes them de facto
public. As the attached log (huge thanks to Flameeyes for making it) shows,
many/most of those are actually used by other projects.

> 
> old team: technical reviews
> new team: political reviews because they plain dont know they code for which
>           they review, the people knowing have been kicked out
> 

If you have some specific functions that should be kept private in mind,
please say which ones. But keep your insults to yourself.

-- 
Anton Khirnov
-------------- next part --------------
/media/tinderbox/usr/lib/libavformat.so.52.84.0:          U ff_toupper4 at LIBAVCODEC_52
/media/tinderbox/usr/lib/libavformat.so.52.84.0:          U ff_aac_parse_header at LIBAVCODEC_52
/media/tinderbox/usr/lib/libavformat.so.52.84.0:          U ff_mpeg4audio_sample_rates at LIBAVCODEC_52
/media/tinderbox/usr/lib/libavformat.so.52.84.0:          U ff_flac_parse_streaminfo at LIBAVCODEC_52
/media/tinderbox/usr/lib/libavformat.so.52.84.0:          U ff_copy_pce_data at LIBAVCODEC_52
/media/tinderbox/usr/lib/libavformat.so.52.84.0:          U ff_find_start_code at LIBAVCODEC_52
/media/tinderbox/usr/lib/libavformat.so.52.84.0:          U ff_split_xiph_headers at LIBAVCODEC_52
/media/tinderbox/usr/lib/libavformat.so.52.84.0:          U ff_mpeg4audio_get_config at LIBAVCODEC_52
/media/tinderbox/usr/lib/libavformat.so.52.84.0:          U ff_mpa_decode_header at LIBAVCODEC_52
/media/tinderbox/usr/lib/libavformat.so.52.84.0:          U ff_dv_frame_profile at LIBAVCODEC_52
/media/tinderbox/usr/lib/libavformat.so.52.84.0:          U ff_mpegaudio_decode_header at LIBAVCODEC_52
/media/tinderbox/usr/lib/libavformat.so.52.84.0:          U ff_ac3_parse_header at LIBAVCODEC_52
/media/tinderbox/usr/lib/libavformat.so.52.84.0:          U ff_flac_parse_block_header at LIBAVCODEC_52
/media/tinderbox/usr/lib/libavformat.so.52.84.0:          U ff_frame_rate_tab at LIBAVCODEC_52
/media/tinderbox/usr/lib/libavformat.so.52.84.0:          U ff_flac_is_extradata_valid at LIBAVCODEC_52
/media/tinderbox/usr/lib/libavformat.so.52.84.0:          U ff_log2_tab at LIBAVUTIL_50
/media/tinderbox/usr/lib/libavformat.so.52.84.0:          U ff_mpa_freq_tab at LIBAVCODEC_52
/media/tinderbox/usr/lib/libavformat.so.52.84.0:          U ff_dv_codec_profile at LIBAVCODEC_52
/media/tinderbox/usr/lib/libavformat.so.52.84.0:          U ff_mpa_bitrate_tab at LIBAVCODEC_52
/media/tinderbox/usr/lib/libavformat.so.52.84.0:          U ff_dirac_parse_sequence_header at LIBAVCODEC_52
/media/tinderbox/usr/lib/xbmc/xbmc.bin:          U url_set_interrupt_cb at LIBAVFORMAT_52
/media/tinderbox/usr/lib/xbmc/xbmc.bin:          U get_partial_buffer at LIBAVFORMAT_52
/media/tinderbox/usr/lib/xbmc/xbmc.bin:          U url_fclose at LIBAVFORMAT_52
/media/tinderbox/usr/lib/xbmc/xbmc.bin:          U put_be16 at LIBAVFORMAT_52
/media/tinderbox/usr/lib/xbmc/xbmc.bin:          U url_feof at LIBAVFORMAT_52
/media/tinderbox/usr/lib/xbmc/xbmc.bin:          U url_fopen at LIBAVFORMAT_52
/media/tinderbox/usr/lib/xbmc/xbmc.bin:          U init_put_byte at LIBAVFORMAT_52
/media/tinderbox/usr/lib/xbmc/xbmc.bin:          U put_be32 at LIBAVFORMAT_52
/media/tinderbox/usr/lib/xbmc/xbmc.bin:          U url_close_dyn_buf at LIBAVFORMAT_52
/media/tinderbox/usr/lib/xbmc/xbmc.bin:          U url_open_dyn_buf at LIBAVFORMAT_52
/media/tinderbox/usr/lib/xbmc/xbmc.bin:          U url_fseek at LIBAVFORMAT_52
/media/tinderbox/usr/lib/xbmc/xbmc.bin:          U put_buffer at LIBAVFORMAT_52
/media/tinderbox/usr/lib/xbmc/xbmc.bin:          U put_byte at LIBAVFORMAT_52
/media/tinderbox/usr/lib/xbmc/xbmc.bin:          U url_fdopen at LIBAVFORMAT_52
/media/tinderbox/usr/lib/xbmc/xbmc.bin:          U dump_format at LIBAVFORMAT_52
/media/tinderbox/usr/lib/xbmc/xbmc.bin:          U get_buffer at LIBAVFORMAT_52
/media/tinderbox/usr/lib/gnash/libgnashmedia-0.8.8.so:          U audio_resample at LIBAVCODEC_52
/media/tinderbox/usr/lib/gnash/libgnashmedia-0.8.8.so:          U audio_resample_init at LIBAVCODEC_52
/media/tinderbox/usr/lib/gnash/libgnashmedia-0.8.8.so:          U audio_resample_close at LIBAVCODEC_52
/media/tinderbox/usr/lib/gnash/libgnashmedia-0.8.8.so:          U init_put_byte at LIBAVFORMAT_52
/media/tinderbox/usr/lib/libavcodec.so.52.96.0:          U ff_set_systematic_pal2 at LIBAVCORE_0
/media/tinderbox/usr/lib/libavcodec.so.52.96.0:          U ff_sqrt_tab at LIBAVUTIL_50
/media/tinderbox/usr/lib/libavcodec.so.52.96.0:          U ff_log2_tab at LIBAVUTIL_50
/media/tinderbox/usr/lib/libavdevice.so.52.2.2:          U dv_init_demux at LIBAVFORMAT_52
/media/tinderbox/usr/lib/libavdevice.so.52.2.2:          U dv_produce_packet at LIBAVFORMAT_52
/media/tinderbox/usr/lib/libavdevice.so.52.2.2:          U dv_get_packet at LIBAVFORMAT_52
/media/tinderbox/usr/lib/vdr/plugins/libvdr-softplay.so.1.6.0:          U dump_format at LIBAVFORMAT_52
/media/tinderbox/usr/lib/vdr/plugins/libvdr-softdevice.so.1.6.0:          U init_put_byte at LIBAVFORMAT_52
/media/tinderbox/usr/lib/jubler/libffdecode.so:          U url_fopen at LIBAVFORMAT_52
/media/tinderbox/usr/lib/jubler/libffdecode.so:          U guess_format at LIBAVFORMAT_52
/media/tinderbox/usr/lib/jubler/libffdecode.so:          U dump_format at LIBAVFORMAT_52
/media/tinderbox/usr/lib/jubler/libffdecode.so:          U url_fclose at LIBAVFORMAT_52
/media/tinderbox/usr/lib/transcode/filter_resample.so:          U audio_resample_init at LIBAVCODEC_52
/media/tinderbox/usr/lib/transcode/filter_resample.so:          U audio_resample_close at LIBAVCODEC_52
/media/tinderbox/usr/lib/transcode/filter_resample.so:          U audio_resample at LIBAVCODEC_52
/media/tinderbox/usr/lib/mlt/libmltavformat.so:          U url_fopen at LIBAVFORMAT_52
/media/tinderbox/usr/lib/mlt/libmltavformat.so:          U url_exist at LIBAVFORMAT_52
/media/tinderbox/usr/lib/mlt/libmltavformat.so:          U audio_resample_close at LIBAVCODEC_52
/media/tinderbox/usr/lib/mlt/libmltavformat.so:          U ff_cropTbl at LIBAVCODEC_52
/media/tinderbox/usr/lib/mlt/libmltavformat.so:          U audio_resample at LIBAVCODEC_52
/media/tinderbox/usr/lib/mlt/libmltavformat.so:          U url_fclose at LIBAVFORMAT_52
/media/tinderbox/usr/lib/vlc/plugins/demux/libavformat_plugin.so:          U init_put_byte at LIBAVFORMAT_52
/media/tinderbox/usr/lib/vlc/plugins/access/libaccess_avio_plugin.so:          U url_seek at LIBAVFORMAT_52
/media/tinderbox/usr/lib/vlc/plugins/access/libaccess_avio_plugin.so:          U url_filesize at LIBAVFORMAT_52
/media/tinderbox/usr/lib/vlc/plugins/access/libaccess_avio_plugin.so:          U url_set_interrupt_cb at LIBAVFORMAT_52
/media/tinderbox/usr/lib/vlc/plugins/access/libaccess_avio_plugin.so:          U url_open at LIBAVFORMAT_52
/media/tinderbox/usr/lib/vlc/plugins/access/libaccess_avio_plugin.so:          U url_close at LIBAVFORMAT_52
/media/tinderbox/usr/lib/vlc/plugins/access/libaccess_avio_plugin.so:          U url_read at LIBAVFORMAT_52
/media/tinderbox/usr/bin/ffmpeg2theora:          U dump_format at LIBAVFORMAT_52
/media/tinderbox/usr/bin/ffmpeg2theora:          U audio_resample_close at LIBAVCODEC_52
/media/tinderbox/usr/bin/ffmpeg2theora:          U audio_resample at LIBAVCODEC_52
/media/tinderbox/usr/bin/ffprobe:          U dump_format at LIBAVFORMAT_52
/media/tinderbox/usr/bin/ffprobe:          U parse_date at LIBAVFORMAT_52
/media/tinderbox/usr/bin/ffmpeg:          U url_fopen at LIBAVFORMAT_52
/media/tinderbox/usr/bin/ffmpeg:          U dump_format at LIBAVFORMAT_52
/media/tinderbox/usr/bin/ffmpeg:          U url_fsize at LIBAVFORMAT_52
/media/tinderbox/usr/bin/ffmpeg:          U parse_date at LIBAVFORMAT_52
/media/tinderbox/usr/bin/ffmpeg:          U url_exist at LIBAVFORMAT_52
/media/tinderbox/usr/bin/ffmpeg:          U audio_resample_close at LIBAVCODEC_52
/media/tinderbox/usr/bin/ffmpeg:          U url_set_interrupt_cb at LIBAVFORMAT_52
/media/tinderbox/usr/bin/ffmpeg:          U audio_resample at LIBAVCODEC_52
/media/tinderbox/usr/bin/ffmpeg:          U url_fclose at LIBAVFORMAT_52
/media/tinderbox/usr/bin/ffmpeg:          U url_ftell at LIBAVFORMAT_52
/media/tinderbox/usr/bin/mpd:          U url_open at LIBAVFORMAT_52
/media/tinderbox/usr/bin/mpd:          U url_read at LIBAVFORMAT_52
/media/tinderbox/usr/bin/mpd:          U url_seek at LIBAVFORMAT_52
/media/tinderbox/usr/bin/mpd:          U url_close at LIBAVFORMAT_52
/media/tinderbox/usr/bin/mpd:          U url_filesize at LIBAVFORMAT_52
/media/tinderbox/usr/bin/bombono-dvd:          U ff_codec_get_tag at LIBAVFORMAT_52
/media/tinderbox/usr/bin/bombono-dvd:          U dump_format at LIBAVFORMAT_52
/media/tinderbox/usr/bin/electricsheep:          U url_fopen at LIBAVFORMAT_52
/media/tinderbox/usr/bin/electricsheep:          U guess_format at LIBAVFORMAT_52
/media/tinderbox/usr/bin/dvdstyler:          U url_exist at LIBAVFORMAT_52
/media/tinderbox/usr/bin/dvdstyler:          U url_fsize at LIBAVFORMAT_52
/media/tinderbox/usr/bin/dvdstyler:          U guess_format at LIBAVFORMAT_52
/media/tinderbox/usr/bin/dvdstyler:          U audio_resample_close at LIBAVCODEC_52
/media/tinderbox/usr/bin/dvdstyler:          U dump_format at LIBAVFORMAT_52
/media/tinderbox/usr/bin/dvdstyler:          U audio_resample at LIBAVCODEC_52
/media/tinderbox/usr/bin/dvdstyler:          U url_fclose at LIBAVFORMAT_52
/media/tinderbox/usr/bin/dvdstyler:          U url_fopen at LIBAVFORMAT_52
/media/tinderbox/usr/bin/ffplay:          U url_feof at LIBAVFORMAT_52
/media/tinderbox/usr/bin/ffplay:          U dump_format at LIBAVFORMAT_52
/media/tinderbox/usr/bin/ffplay:          U url_fsize at LIBAVFORMAT_52
/media/tinderbox/usr/bin/ffplay:          U url_ferror at LIBAVFORMAT_52
/media/tinderbox/usr/bin/ffplay:          U parse_date at LIBAVFORMAT_52
/media/tinderbox/usr/bin/ffplay:          U url_set_interrupt_cb at LIBAVFORMAT_52
/media/tinderbox/usr/bin/ffplay:          U url_ftell at LIBAVFORMAT_52
/media/tinderbox/usr/bin/kino:          U url_close_buf at LIBAVFORMAT_52
/media/tinderbox/usr/bin/kino:          U url_open_buf at LIBAVFORMAT_52
/media/tinderbox/usr/bin/kino:          U guess_format at LIBAVFORMAT_52
/media/tinderbox/usr/bin/vdr2jpeg:          U url_fclose at LIBAVFORMAT_52
/media/tinderbox/usr/bin/vdr2jpeg:          U dump_format at LIBAVFORMAT_52
/media/tinderbox/usr/bin/vdr2jpeg:          U guess_format at LIBAVFORMAT_52
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110219/1e38e8d4/attachment.pgp>

More information about the ffmpeg-devel mailing list