[FFmpeg-devel] About guess_correct_pts / AVFrame.best_effort_timestamp

[Måns Rullgård]

Nicolas George <nicolas.george at normalesup.org> writes:

> L'octidi 28 pluvi?se, an CCXIX, M?ns Rullg?rd a ?crit?:
>> What did you "check"?
>
> That guess_correct_pts gives coherent timestamps.
>
>>			Please try this command:
>> 
>> ffmpeg -i foo.mkv -vcodec copy -acodec copy foo.mp4
>
> The code we are discussing is not used in copy mode, as it is only called
> during avcodec_decode_video2.

With the same bad inputs as trigger the error you see in copy mode.

> There is indeed an issue there, and it certainly needs fixing, but this is a
> completely unrelated issue to the topic of this thread, and it is not a
> valid reason to reject the patch.

The topic of the thread is timestamps.  Your patch does not fix any
existing problem in the timestamp handling.  All it does is make some
broken guesswork part of the API.  On those grounds, the patch is
rejected.

-- 
M?ns Rullg?rd
mans at mansr.com