[FFmpeg-devel] [PATCH] Cosmetics: adopt compact notation in disabled code.

[Stefano Sabatini]

On date Monday 2011-02-14 10:32:54 +0000, M?ns Rullg?rd encoded:
> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
[...]
> > Subject: [PATCH] In ffplay adopt compact notation in code which sets aspect ration from
> >  the DTG active format.
> >
> > This is legacy code, since it's not clear why it was left behind I'm
> > leaving the logic untouched. Improve readability.
> > ---
> >  ffplay.c |   28 +++++++---------------------
> >  1 files changed, 7 insertions(+), 21 deletions(-)
> >
> > diff --git a/ffplay.c b/ffplay.c
> > index 170acfd..be26150 100644
> > --- a/ffplay.c
> > +++ b/ffplay.c
> > @@ -723,27 +723,13 @@ static void video_image_display(VideoState *is)
> >  #if 0
> >          switch(is->video_st->codec->dtg_active_format) {
> >          case FF_DTG_AFD_SAME:
> 
> That code has _never_ been enabled.  Just delete it.
> 
> The DTG thing appears to be some additional aspect ratio signalling used
> in DVB, and this is clearly the wrong way to handle it.  It does not
> belong in AVCodecContext at all IMHO.  Instead, the decoder should set
> sample_aspect_ratio properly.

OK, you convinced me.

I confirm that the code was there since the inception of ffplay, and
never enabled.
-- 
FFmpeg = Fantastic and Fast Mournful Prodigious Extroverse Gigant