[FFmpeg-devel] [PATCH 2/2] mmst: don't look for a hr field in ping messages

Ronald S. Bultje rsbultje
Sun Feb 13 15:31:18 CET 2011


Hi,

On Sun, Feb 13, 2011 at 7:35 AM, Francesco Cosoleto <cosoleto at gmail.com> wrote:
> Il 12/02/2011 22:45, Ronald S. Bultje ha scritto:
>> The attached patch fixes it also, and is IMO more correct.
>>
> Surely it works, nevertheless in theory MMS specs includes a packet,
> SC_PKT_PASSWORD_REQUIRED (0x1a), without 'hr' field and with size
> greater than ping packet. Identify these server messages before of
> reading the hr value doesn't look to me so bad.

How big? Ping packet is 36 bytes I think, hr is 40-44, so the check is
simple enough.

Ronald



More information about the ffmpeg-devel mailing list