[FFmpeg-devel] [PATCH] Cosmetics: adopt compact notation in disabled code.

[Måns Rullgård]

Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:

> On date Saturday 2011-02-12 17:55:06 +0000, M?ns Rullg?rd encoded:
>> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
>> 
>> > Improve readability.
>> > ---
>> >  ffplay.c |   30 +++++++-----------------------
>> >  1 files changed, 7 insertions(+), 23 deletions(-)
>> >
>> > diff --git a/ffplay.c b/ffplay.c
>> > index de2a594..bd0ec73 100644
>> > --- a/ffplay.c
>> > +++ b/ffplay.c
>> > @@ -724,31 +724,15 @@ static void video_image_display(VideoState *is)
>> >              is->dtg_active_format = is->video_st->codec->dtg_active_format;
>> >              printf("dtg_active_format=%d\n", is->dtg_active_format);
>> >          }
>> > -#endif
>> > -#if 0
>> >          switch(is->video_st->codec->dtg_active_format) {
>> 
>> Why is this #if 0 block there at all?
>
> Legacy code, I don't have the time to inquire now but with the compact
> notation I get less "distracted" by it.

Is there any reason to believe it is useful at all?  Does it even
compile if enabled?

-- 
M?ns Rullg?rd
mans at mansr.com