[FFmpeg-devel] [PATCH 2/2] ac3enc: Remove unneeded clipping of shift amount.

Luca Barbato lu_zero
Thu Feb 10 23:02:47 CET 2011


On 02/10/2011 10:34 PM, Justin Ruggles wrote:
> On 02/10/2011 04:15 PM, Justin Ruggles wrote:
> 
>>
>> log2_tab() only works with range [-32767,32767] due to abs(), so the return
>> value will always be in the range [0,14].
>> ---
>>  libavcodec/ac3enc_fixed.c |    1 -
>>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> 
> Sorry, this comment isn't true. but it still will always return 0 to 14
> because the range is limited by the window function.

Amend the comment please.

Otherwise seems fine.

lu

-- 

Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero




More information about the ffmpeg-devel mailing list