[FFmpeg-devel] [PATCH] movie video source

[Janne Grunau]

On Tue, Feb 01, 2011 at 07:58:22PM +0100, Michael Niedermayer wrote:
> On Sun, Jan 30, 2011 at 06:19:42PM +0100, Stefano Sabatini wrote:
> > On date Sunday 2011-01-30 16:15:10 +0100, Michael Niedermayer encoded:
> > > On Sun, Jan 30, 2011 at 12:32:25AM +0100, Stefano Sabatini wrote:
> > > [...]
> > > > +    if (movie->seek_point_d > (INT64_MAX-0.5) / 1000000) {
> > > > +        av_log(ctx, AV_LOG_ERROR, "Value for seek point is too big\n");
> > > > +        return AVERROR(EINVAL);
> > > > +    }
> > > 
> > > i think you can set the max in the AVOptions table correctly
> > 
> > Added, I'm using (INT64_MAX-1) / 1000000 for preventing rounding
> > errors.
> > 
> > Also added one more check on the seeking value for preventing overflow
> > when doing movie->seek_point + start_time.
> > 
> > > except that lgtm if tested
> > -- 
> > FFmpeg = Fast and Fiendish Magic Proud Erratic Ghost
> 
> >  Changelog                |    1 
> >  doc/filters.texi         |   55 ++++++++
> >  libavfilter/Makefile     |    2 
> >  libavfilter/allfilters.c |    1 
> >  libavfilter/avfilter.h   |    2 
> >  libavfilter/vsrc_movie.c |  311 +++++++++++++++++++++++++++++++++++++++++++++++
> >  6 files changed, 371 insertions(+), 1 deletion(-)
> > e18fa675d3a121829d5dd341910fd656b2d6df35  0005-Add-video-movie-source.patch
> 
> lgtm if tested
> also a reg test would be nice

queued

Janne