[FFmpeg-devel] [PATCH] Fix broken vbv_buffer_init handling in libx264.c

[Jason Garrett-Glaser]

On Sun, Feb 6, 2011 at 6:22 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> Hi,
>
> On Sun, Feb 6, 2011 at 8:11 AM, Jason Garrett-Glaser <jason at x264.com> wrote:
>> Due to being pants-on-head retarded, libavcodec defaults this to zero, which
>> results in broken output. ?This didn't affect ffmpeg.c, which sets it itself,
>> but caused problems for other calling apps using VBV.
>
> Shouldn't you fix that and have avcodec_set_defaults() set a proper
> default instead of ffmpeg.c?
>
> Ronald
>

Impossible, because vbv_buffer_init is a fraction of the total vbv
buffer.  Currently we don't have defaults that can be set based on
user-set options.

This is a flaw in the option: it should be a scale (0 to 1) instead of
an absolute size.

Jason