[FFmpeg-devel] [PATCH 2/2] Add sample_aspect_ratio fields to vsrc_buffer arguments. This fixes aspect handling in ffmpeg This is based on a patch by baptiste

Stefano Sabatini stefano.sabatini-lala
Sun Feb 6 16:03:56 CET 2011


On date Sunday 2011-02-06 00:26:17 +0100, Michael Niedermayer encoded:
> On Sat, Feb 05, 2011 at 04:27:32PM +0100, Stefano Sabatini wrote:
> > On date Friday 2011-02-04 17:11:41 -0800, Baptiste Coudurier encoded:
> > > On 02/04/2011 12:33 AM, Stefano Sabatini wrote:
> > > >[...]
> > > >
> > > >  }
> > > >@@ -2825,6 +2835,12 @@ static void opt_frame_pix_fmt(const char *arg)
> > > >
> > > >  static void opt_frame_aspect_ratio(const char *arg)
> > > >  {
> > > >+#if CONFIG_AVFILTER
> > > >+    av_log(NULL, AV_LOG_ERROR,
> > > >+           "Option 'aspect' is incompatible with filters, "
> > > >+           "use -vf together with the setdar filter instead\n");
> > > >+    ffmpeg_exit(1);
> > > >+#else
> > > 
> > > Seriously guys, can you please stop this nonsense ?
> > > -aspect is used with stream copy as well.
> >
> > New tentative approach, tested with CONFIG_AVFILTER = 1, -aspect N:D
> > -vf F, -vf F -aspect N:D, stream copy and CONFIG_AVFILTER = 0,
> > regression test passed.
> 
> dont forget to test that your cases get aspects both on init time as well as
> per frame time correct

I don't think this was never supported, so I'd rather skip it for now
(which should be addressed by filtegraph dynamic reconfiguration).
-- 
FFmpeg = Fabulous Faithful Mysterious Pure Exciting God



More information about the ffmpeg-devel mailing list