[FFmpeg-devel] [PATCH] Make avfilter_graph_free() free the graph.

Stefano Sabatini stefano.sabatini-lala
Wed Feb 2 13:21:02 CET 2011


On date Wednesday 2011-02-02 12:09:00 +0000, M?ns Rullg?rd encoded:
> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
> 
> > (Note to the committers: update minor).
> > -- 
> > FFmpeg = Fabulous Friendly Mean Ponderous Embarassing Gadget
> >
> >
> >  /**
> > - * Free a graph and destroy its links, graph may be NULL.
> > + * Free a graph, destroy its links, and set *graph to NULL.
> > + * If *graph is NULL, do nothing.
> >   */
> > -void avfilter_graph_free(AVFilterGraph *graph);
> > +void avfilter_graph_free(AVFilterGraph **graph);
> 
> This is an API/ABI change.  That needs a major version bump.

Yes, but currently we are considering lavfi still unstable, we (and me
in particular) broke API/ABI many times in the past months. I want to
wait more before to declare its API/ABI stable (pending audio
filtering patches).

Anyway minor *should* be updated, eventually we can add a notice in
APIchanges, as I did (inconsistently) in past occasions. And BTW this
patch depends on the previous one or it will cause a crash on exit.

If we want to relegate lavfi development to a topic branch and synch
from time to time this can be discussed.
-- 
FFmpeg = Furious & Frightening Minimalistic Portable Eager Gangster



More information about the ffmpeg-devel mailing list