[FFmpeg-devel] [PATCH] Implement AAC Long Term Prediction (LTP) decoding module

[Diego Biurrun]

On Tue, Feb 01, 2011 at 12:50:42PM +0000, M?ns Rullg?rd wrote:
> Diego Biurrun <diego at biurrun.de> writes:
> 
> > On Tue, Feb 01, 2011 at 10:57:28AM +0900, Young Han Lee wrote:
> >> 
> >> please check it again. :)
> >
> > Looks good now.  Some more nits for your Doxygen comments below, but
> > don't bother sending a new patch.  Wait for the review from Alex first.
> >
> >> --- a/libavcodec/aacdec.c
> >> +++ b/libavcodec/aacdec.c
> >> @@ -1682,23 +1706,108 @@ static void apply_tns(float coef[1024], TemporalNoiseShaping *tns,
> >> +/**
> >> + * Windowing and MDCT to obtain the spectral coefficient from the predicted sample by LTP
> >
> > This is a longish line that you could break and end in a period.
> > The sentence would also be easier to understand if there was a
> > verb in it.
> 
> "Obtain" is a verb.  Agree about the line length.

"Obtain", however, is not the predicate of the sentence.  With predicate
it should read something like

  Apply/use/frobnicate windowing and MDCT to obtain the spectral
  coefficient from the predicted sample by LTP.

Diego