[FFmpeg-devel] [PATCH 1/3] flvdec: Check index for being valid Fixes seeking in Enigma_Principles_of_Lust.flv
Derek Buitenhuis
derek.buitenhuis at gmail.com
Fri Dec 30 02:01:32 CET 2011
On 29/12/2011 7:38 PM, Michael Niedermayer wrote:
> - if (timeslen == fileposlen && fileposlen && max_pos <= filepositions[0]) {
> + if (timeslen == fileposlen && fileposlen>1 && max_pos <= filepositions[0]) {
I'm not sure where the >1 comes in? Wouldn't this change behavior
on previously working files?
> + size0 = avio_rb32(ioc);
> + avio_r8(ioc);
Does this stray avio_r8() act like a skip? Sorry for having to ask.
> + if (size0 > filepositions[1] || FFABS(dts - times[1]*1000)>5000)
Where does this magic number (5000) come from? Again, sorry if I missed
this.
- Derek
More information about the ffmpeg-devel
mailing list