[FFmpeg-devel] [PATCH] Revert "build: error on mixed declarations and code"

Alexander Strasser eclipse7 at gmx.net
Thu Dec 29 22:44:36 CET 2011


Hi Nicolas,

Nicolas George wrote:
> This reverts commit 9d6b2077b27980936efdc616e2f9c92a56b443fc.
> 
> This error is annoying while debugging, and if someone disables it for
> convenience, it raises the odds of leaving ffmpeg unbuildable by default.
> 
> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> ---
> 
> 
> Carl Eugen Hoyos:
> > Imo, please revert and push.
> 
> I'll do that pretty soon.
> 
> 
> Alexander Strasser:
> > couldn't it be easily simulated for debugging like in:
> 
> Of course, but it takes more step for no good reason I can see. It looks as
> if the people who pushed this do not trust their own developers.

  As I said in the parts of that message you didn't quote, I am fine with
reverting it. I have no hard opinions on this one, but personally I tend
to not use that flag.

  Just wanted to make this clear.

  Alexander


More information about the ffmpeg-devel mailing list