[FFmpeg-devel] Trans.: a64multienc.c and drawutils.c optimisations

[yann.lepetitcorps at free.fr]

> On Wed, Dec 28, 2011 at 04:35:04AM +0100, yann.lepetitcorps at free.fr wrote:
> [...]
> >
> > I have a make a new diff file that compile the majority of the needed
> > corrections
> >
> > PS : is better to add the last post at the beginning (we see instantly the
> > lastest modification at the opening of the mail) or to add the last post at
> the
> > end (the discusion is stored in the natural order) [cf. FIFO vs FILO order]
> ?
>
> best is to replace irrelevant parts of the mail by [...]
> and then place the reply interleaved under each relevant part
>

Thanks for the tips, Michael
This is really better as this :)


> > +int adpcm_nibble_diff_step_tab[8] = { 0, 4, 2, 6, 1, 3, 5, 7 };
> > +
> >  static inline int adpcm_ima_qt_expand_nibble(ADPCMChannelStatus *c, int
> nibble, int shift)
> >  {
> >      int step_index;
> > @@ -169,11 +171,13 @@ static inline int
> adpcm_ima_qt_expand_nibble(ADPCMChannelStatus *c, int nibble,
> >      step = ff_adpcm_step_table[c->step_index];
> >      step_index = c->step_index + ff_adpcm_index_table[nibble];
> >      step_index = av_clip(step_index, 0, 88);
> > -
> > +/*
> >      diff = step >> 3;
> >      if (nibble & 4) diff += step;
> >      if (nibble & 2) diff += step >> 1;
> >      if (nibble & 1) diff += step >> 2;
> > +*/
> > +    diff =  (adpcm_nibble_diff_step_tab[nibble &0x7]+8) * step;
>
> see adpcm_ima_expand_nibble()
> one problem though is that this is not producing the same result

I have tested nothing :(

I think that the adpcm_nibble_diff_step_tab[] and/or the diff computation aren't
corrects (but the idea is here)

What is the good way for to test "randomly" modifications ?


> also it is best to send each self contained change in a seperate patch,
> like 1 patch for the adpcm change and one patch for the drawutils.

What is the needed command for to have the 'git diff' but only for somes files ?

> also i suggest to configure your editor so it inserts spaces when you
> hit the tab key and so that it removes trailing whitespace, both are
> forbidden in ffmpeg git.

I have now actived the "Edition/Préférences/Editeur/Insérer des espaces au
lieu des tabulations" option in gedit


> Thanks
>

A lot of thanks to your precious help  :)


@+
Yannoo