[FFmpeg-devel] [RFC][PATCH] Rudimentary support for id3v2 APIC tags.

[Adrian Drzewiecki]

On Dec 24, 2011, at 12:00 PM, Nicolas George wrote:

> Le quartidi 4 nivôse, an CCXX, Adrian Drzewiecki a écrit :
>> When parsing id3 tags, if an APIC tag is encountered, add it
>> to the tag dictionary encoded as "<mime type>\0<4 byte data len>\0<data>".
> 
> I did not read the rest, but I think it would be better to have proper
> support for MIME type (or any kind of type description) and binary data
> directly in the data structures.
> 
> Regards,
> 
> -- 
>  Nicolas George

Thanks. How about this then: extend AVDictionaryEntry with two fields:

AVDictionaryEntry {
   char *key;
   char *value;
   void *data;
   int size;
};

And a new function av_dict_set_data().

Thoughts?
-Adrian