[FFmpeg-devel] [PATCH] fate: give stderr hint when a test fails.

[Alexander Strasser]

Hi,

 I like your patch. Just a few comments.

Clément Bœsch wrote:
> ---
>  tests/fate-run.sh |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/tests/fate-run.sh b/tests/fate-run.sh
> index 350ff57..7f6b886 100755
> --- a/tests/fate-run.sh
> +++ b/tests/fate-run.sh
> @@ -136,5 +136,9 @@ fi
>  
>  echo "${test}:${sig:-$err}:$($base64 <$cmpfile):$($base64 <$errfile)" >$repfile
>  
> -test $err = 0 && rm -f $outfile $errfile $cmpfile $cleanfiles
> +if [ $err -eq 0 ]; then

  Any particular reason not to use "if test $err = 0; then"?

> +    rm -f $outfile $errfile $cmpfile $cleanfiles
> +else
> +    echo "test failed, stderr output available here in $errfile"

  Is the "here" in the output really helpful? Maybe it could be just
omitted. The whole message is a bit terse.

  Alternative suggestion:
  "Warning: Test failed. Look at $errfile for details."

> +fi
>  exit $err

  Alexander