[FFmpeg-devel] [PATCH] fate: warn if SAMPLES is not specified.

[Reimar Döffinger]

On Thu, Dec 22, 2011 at 04:23:05PM +0100, Clément Bœsch wrote:
> ---
>  tests/Makefile |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/Makefile b/tests/Makefile
> index b44db7d..d825cd8 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -108,9 +108,13 @@ fate-seek:   $(FATE_SEEK)
>  
>  ifdef SAMPLES
>  FATE += $(FATE_TESTS) $(FATE_TESTS-yes)
> +fate: $(FATE)
>  fate-rsync:
>  	rsync -vaLW --timeout=60 --contimeout=60 rsync://fate.ffmpeg.org/fate-suite/ $(SAMPLES)
>  else
> +fate-samples-warning:
> +	@echo "warning: only a subset of the fate tests will be run because SAMPLES is not specified"
> +fate: fate-samples-warning $(FATE)
>  fate-rsync:
>  	@echo "use 'make fate-rsync SAMPLES=/path/to/samples' to sync the fate suite"
>  $(FATE_TESTS):
> @@ -121,8 +125,6 @@ FATE_UTILS = base64 tiny_psnr
>  
>  TOOL = ffmpeg
>  
> -fate: $(FATE)
> -

Hm, I don't think that should be necessary to change, just specifying
the additional fate-samples-warning dependency should work.
However particularly with -j <n> it can be printed whenever.
(I am not completely sure about the ':' vs. '::' syntax, might be you
have to switch to using ::, but at least duplicating it completely
should not be necessary).
Alternatively you could just do a
FATE += fate-samples-warning
but that would probably print it at the end - whether that is better or
worse would be up to discussion.