[FFmpeg-devel] [PATCH] libopenjpegdec: fix rgb24 decoding regression from commit eb511ef6

[Alex Zhukov]

lets see what the code path would be for PIX_FMT_RGB24
in check_image_attributes
the compRatio should be anything but 0111111/0112121/0112222, which means
non-equal component size rgb24 (haven't heard of one yet)

or if it's equal component size - precision is checked to be 8 to return
rgb24:
    switch (c0.prec) {
    case 8:  return PIX_FMT_RGB24;

i'm fine with applying the patch, there's nothing wrong with it, but to me
it's a bit of premature optimization.
isnt it mostly a matter of taste?
to my taste i'd just wait to see if someone finds an example where error is
triggered.

On Thu, Dec 22, 2011 at 10:27 AM, Jean First <jeanfirst at gmail.com> wrote:

> On Wed Dec 21 21:26:45 2011, Alex Zhukov wrote:
>
>> from the top of my head: copyto8 expects the 8bit precision therefore no
>> ">>adjust" should be needed
>> can you provide an example video where this is not the case?
>>
>> On Wed, Dec 21, 2011 at 5:33 AM, Jean First<jeanfirst at gmail.com>  wrote:
>>
>>  Hi,
>>>
>>> attached patch fixes a regression introduced with commit eb511ef6.
>>> maybe libopenjpeg_copyto8 and libopenjpeg_copyto16 need this fix too.
>>>  Alex Zhukov, can you please check this ?
>>>
>>> Jean
>>>
>>> ---
>>>
>>
> Hi Alex,
> No atm not. I suggest to apply the patch until we have a sample that
> triggers the error.
> Jean
>
> ______________________________**_________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/**listinfo/ffmpeg-devel<http://ffmpeg.org/mailman/listinfo/ffmpeg-devel>
>