[FFmpeg-devel] [PATCH] Clearer wording of audio channel maping limitations

[Clément Bœsch]

On Wed, Dec 21, 2011 at 04:18:53PM +0000, Tim Nicholson wrote:
[...]
> >> -Note that "-map_channel" is currently limited to the scope of one input for
> >> -each output; you can't for example use it to pick multiple input audio files
> >> -and mix them into one single output.
> >> +Note that "-map_channel" is currently limited to the scope of one input stream for
> >> +each output stream;
> >
> >Adding "stream" is indeed a good idea. I'd actually even reword it
> >emphasis that "one output stream is associated with one single input
> >stream"; I think it's easier to visualize that the output stream can't be
> >composed of multiple inputs. It enlightens the fact that -map_channel is
> >(currently) limited to filtering and reordering.
> 
> OK then, a bolder rewording......
> 

Since you're changing the paragraph anyway, let's take the opportunity to
fix the whole thing :)

> Should I keep them as separate patch stages, or should I have merged them?
> 
> I tried a rebase but nothing happened....
> 

You need to edit your patch and submit it again. The simpler thing to do
in your case is to do some changes and then commit them with `git commit
-a --amend`. It should squash your changes within the last commit.

> >
> >>                      you can't, for example, use it to pick multiple input audio channels
> >> +contained in different streams (from the same or different files) and mix them into one single
> >> +output stream in order to turn two separate mono streams into a single stereo stream.
> >>  
> >
> >You start that part of the sentence with an "abstraction" ("pick multiple
> >input audio channels contained in different streams") and end up with a
> >very specific example; I think it would be better split.
> >
> 
> Interesting observation, as originally I had it split, but then tried to reduce/simplify it...
> 
> >Also, could you keep the 80 columns wrapping?
> 
> Sorry, I was relying on keeping within other, existing, lines that were over 80 ;(

AFAIK that paragraph doesn't have more than 80 characters per line...

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111221/d7b46f92/attachment.asc>