[FFmpeg-devel] [PATCH]Fix an endless loop when decoding amr-nb

Vitor Sessak vitor1001 at gmail.com
Sun Dec 18 02:45:46 CET 2011


On Sat, Dec 17, 2011 at 10:59 PM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> Hi!
>
> On Saturday 17 December 2011 01:07:30 pm Vitor Sessak wrote:
>> On Thu, Dec 15, 2011 at 11:52 PM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
>
>> > +        if (in->pitch_lag)
>> >          do {
>> >              out[x] += y;
>> >              y *= in->pitch_fac;
>>
>> Since we are adding a check anyway, why not check (in->pitch_lag > 0)?
>
> New patch attached.
>
> Thank you, Carl Eugen

LGTM (but please test fate-wmavoice* and fate-amr*).

-Vitor


More information about the ffmpeg-devel mailing list