[FFmpeg-devel] [PATCH]Make systematic palette opaque

[Clément Bœsch]

On Thu, Dec 15, 2011 at 01:14:34AM +0100, Carl Eugen Hoyos wrote:
> Hi!
> 
> Whatever a systematic palette is, I don't think it should be transparent.
> 
> Please comment, Carl Eugen

> diff --git a/libavutil/imgutils.c b/libavutil/imgutils.c
> index 6e97085..3847c53 100644
> --- a/libavutil/imgutils.c
> +++ b/libavutil/imgutils.c
> @@ -175,7 +175,7 @@ int ff_set_systematic_pal2(uint32_t pal[256], enum PixelFormat pix_fmt)
>          default:
>              return AVERROR(EINVAL);
>          }
> -        pal[i] = b + (g<<8) + (r<<16);
> +        pal[i] = b + (g<<8) + (r<<16) + (0xFF<<24);

Isn't this undefined for the MSB? 0xFFU<<24 should be ok, if anyone can
confirm…

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111215/b241a6d6/attachment.asc>