[FFmpeg-devel] [PATCH] ffplay: Add 10 minute seek support

[Takis Issaris]

Hi Marton,

2011/12/14 Takis Issaris <takis.issaris at uhasselt.be>:
> Hi Marton,
>
> 2011/12/14 Marton Balint <cus at passwd.hu>:
>>
>>
>> On Tue, 13 Dec 2011, Takis Issaris wrote:
>>
>>> Hi,
>>>
>>> 2011/12/13 compn <tempn at twmi.rr.com>:
>>>> On Tue, 13 Dec 2011 16:14:40 +0100, Takis Issaris wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> A simple patch I am using locally to ease testing seeking using ffplay.
>>>>>
>>
>> [...]
>>
>> +            case SDLK_PAGEUP:
>> +                incr = -600.0;
>> +                goto do_seek;
>> +            case SDLK_PAGEDOWN:
>> +                incr = 600.0;
>> +                goto do_seek;
>>
>> Isn't mplayer using the opposite by default? E.g seek forward on PgUp, and
>> seek backward on PgDown.
>
> Ah! That makes sense, now I know why I kept seeking backwards by mistake
> all the time :-)
>
>
>> Also this is not consistent with SDLK_UP and
>> SDLK_DOWN, or the help text. If it is OK with you, then I will push this
>> patch with the signs changed.
>
> Yes, sure, the signs should be changed.
>

Here's an updated and rebased patch.


Met vriendelijke groeten,
Takis
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-10-minute-seek-support-to-ffplay.patch
Type: text/x-patch
Size: 1747 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111214/84d62583/attachment.bin>