[FFmpeg-devel] [PATCH]Do not detect mp2 in mxf as mpeg2video

[Reimar Döffinger]

On Sat, Dec 10, 2011 at 12:59:24PM +0100, Tomas Härdin wrote:
> On Sat, 2011-12-10 at 11:53 +0100, Reimar Döffinger wrote:
> > On Sat, Dec 10, 2011 at 10:24:56AM +0100, Reimar Döffinger wrote:
> > > On 10 Dec 2011, at 01:51, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> > > > Reimar Döffinger <Reimar.Doeffinger <at> gmx.de> writes:
> > > > 
> > > >> On Thu, Dec 08, 2011 at 02:37:37PM +0100, Carl Eugen Hoyos wrote:
> > > >>> Attached patches fix ticket #721.
> > > >> 
> > > >> Hm, I really should read mail before starting hacking.
> > > > 
> > > >> I think that the split should be done, as in the second patch.
> > > > 
> > > > As said, this does not work anymore (=the patch does not fix the issue since
> > > > yesterday). Your patch does not help either for me...
> > > 
> > > Uh, both still fix the original issue as far as I can tell (audio getting a video stream codec id).
> > > That the file doesn't play at all is sure a serious issue, but a different one.
> > 
> > Sent patch for that issue.
> > However the new code seems to be designed without the slightest regard
> > to broken or unusual files, despite the majority of MXF files being
> > broken one way or another.
> 
> MXF is complicated, and often ambiguous. Anyway, please put such broken
> files in the FATE suite.
> 
> Anyway, splitting mxf_essence_container_uls seems like a decent
> solution, if both streams have the same essence_container_ul.

They do not, the demuxer is only using 14 bytes of the ULs (as
specified) and completely according to the specification the
first 14 bytes of the ULs MPEG-2 video and audio match.
The reason for splitting them is that it is a really bad idea
to assign a video codec id when we have set codec_type to audio
and vice versa, even when that is actually what is stored in the file.
The alternative is to only lookup up the codec id and set the codec
type automatically based on it, but the current behaviour is just
really bad.