[FFmpeg-devel] [PATCH 1/4] escape130: Check dimensions to be a multiple of the block size.

[Paul B Mahol]

On 12/8/11, Michael Niedermayer <michaelni at gmx.at> wrote:
> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> ---
>  libavcodec/escape130.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/libavcodec/escape130.c b/libavcodec/escape130.c
> index 322ec8f..57327b1 100644
> --- a/libavcodec/escape130.c
> +++ b/libavcodec/escape130.c
> @@ -43,6 +43,11 @@ static av_cold int escape130_decode_init(AVCodecContext
> *avctx)
>      Escape130Context *s = avctx->priv_data;
>      avctx->pix_fmt = PIX_FMT_YUV420P;
>
> +    if((avctx->width&1) || (avctx->height&1)){
> +        av_log(avctx, AV_LOG_ERROR, "Dimensions are not a multiple of the
> block size\n");
> +        return -1;
Irrelevant: if it make sense, could -1 be changed to something better?
Yes, bunch of files use -1 but I'm just curious.

> +    }
> +
>      s->bases= av_malloc(avctx->width * avctx->height /4);
>
>      return 0;

LGTM