[FFmpeg-devel] Subject: [PATCH] Process compressed id3v2 tags.

[Michael Niedermayer]

On Sat, Dec 03, 2011 at 08:14:29PM +0100, Reimar Döffinger wrote:
> On Sat, Dec 03, 2011 at 10:46:46AM -0800, Adrian Drzewiecki wrote:
> > +            char *type;
> 
> "const char *" is more correct.
> 
> > +                for (i = 0, j = 0; i < dlen; i++, j++) {
> > +                    if (tcomp)
> > +                        buffer[j] = avio_r8(s->pb);
> 
> Did you test this to work? Because I'm quite convinced this should be
> "!tcomp"...

I think Adrian said he wanted to be CC-ed

also the patch is a bit messed up in terms of newlines, likely your
MUA wraps lines

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111203/5f9326c8/attachment.asc>