[FFmpeg-devel] [PATCH] lavfi: unify asink_buffer and vsink_buffer API

[Michael Niedermayer]

On Wed, Aug 31, 2011 at 05:50:00PM +0200, Stefano Sabatini wrote:
> On date Wednesday 2011-08-31 04:51:34 +0200, Michael Niedermayer encoded:
> > On Mon, Aug 29, 2011 at 05:10:29PM +0200, Stefano Sabatini wrote:
> > [...]
> > > +    buffersink_params->pixel_fmts = pix_fmts;
> > >  
> > >      ost->graph = avfilter_graph_alloc();
> > >  
> > > @@ -366,7 +368,8 @@ static int configure_video_filters(InputStream *ist, OutputStream *ost)
> > >      if (ret < 0)
> > >          return ret;
> > >      ret = avfilter_graph_create_filter(&ost->output_video_filter, avfilter_get_by_name("buffersink"),
> > > -                                       "out", NULL, pix_fmts, ost->graph);
> > > +                                       "out", NULL, buffersink_params, ost->graph);
> > 
> > these functions are quite similar.
> > A compatibility layer should be quite easy, or am i missing something?
> 
> Updated.
> -- 
> FFmpeg = Fanciful and Fascinating Meaningful Philosophical Esoteric Gadget

>  b/avconv.c                   |   10 ++
>  b/doc/APIchanges             |    7 +
>  b/doc/filters.texi           |    8 -
>  b/ffmpeg.c                   |   10 ++
>  b/ffplay.c                   |   15 ++-
>  b/libavdevice/lavfi.c        |   27 ++++--
>  b/libavfilter/Makefile       |    2 
>  b/libavfilter/vsink_buffer.c |  180 ++++++++++++++++++++++++++++++++++++-------
>  b/libavfilter/vsink_buffer.h |   59 +++++++++++---
>  libavfilter/asink_abuffer.c  |   97 -----------------------
>  libavfilter/asink_abuffer.h  |   47 -----------
>  11 files changed, 263 insertions(+), 199 deletions(-)
> 431803adc16f497c5bf4bc7da1d222aabc8af2d1  0001-lavfi-unify-asink_buffer-and-vsink_buffer-API.patch
> From 2d89fad987b948a8eec32e39fdf715153518e464 Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> Date: Thu, 18 Aug 2011 16:21:47 +0200
> Subject: [PATCH] lavfi: unify asink_buffer and vsink_buffer API
> 
> The new API is more generic (no distinction between audio/video for
> pulling frames), and avoids code duplication.
> 
> A backward compatibility layer is kept for avoiding tools ABI breaks
> (only for the video binary interface, audio interface was never used
> in the tools).

looks good

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110831/ad1364f5/attachment.asc>