On Wed, Aug 31, 2011 at 12:08:56AM +0200, Robert Petka wrote:
> Dňa 30. 8. 2011 22:17, Carl Eugen Hoyos wrote / napísal(a):
>> Robert Petka<robert.petka<at> gmail.com> writes:
>>
>>> Patcheck writes just bunch of grep unrecognized option messages.
>> trailing whitespace
>> patch:23:+
>>
>> x==0 / x!=0 can be simplified to !x / x
>> patch:87:+ if (dp != NULL) {
>>
>> missing } prior to else
>> patch:52:+ else
>>
>> missing whitespace between keyword and ( (feel free to ignore)
>> patch:24:+ for(i=length-1;i>=0;i--)
>> patch:25:+ if(inPath[i] == '\\' || inPath[i] =='/')
>> patch:28:+ if(i == -1) {
>> patch:45:+ for(i=length-1;i>=0;i--) {
>> patch:46:+ if(last_digit == -1) {
>> patch:47:+ if(isdigit(path[i]))
>> patch:50:+ if(isdigit(path[i]))
>> patch:58:+ if(first_digit != -1) {
>> patch:95:+ if(file_index != -1) {
>> patch:96:+ if(file_index< min_index)
>> patch:108:+ if(first_index == -1) {
>>
>> possibly unused variables
>> possibly never read :length
>> possibly never read :length
>>
>> Missing changelog entry (ignore if minor change)
>>
>> FFMIN/FFMAX
>> + if(file_index< min_index)
>> + min_index = file_index;
>>
>> Carl Eugen
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> Thank you :)
>
> I have updated msys to get it work here too. Please find attached patch
> file. Last remaining messages from patcheck:
>
> possibly unused variables
> possibly never read :length
> possibly never read :length
>
> Missing changelog entry (ignore if minor change)
>
>
> I can work on dirname replacement (mentioned by Georgi) tomorrow...
when you do, please write the implementation so as to avoid known
bugs in dirname.
the manpage says (dunno if you have the manpages on msys)
BUGS
In the glibc implementation of the POSIX versions of these functions they modify their argument, and segfault when called with a static string like "/usr/". Before glibc 2.2.1, the glibc version
of dirname() did not correctly handle pathnames with trailing '/' characters, and generated a segfault if given a NULL argument.
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
There seems to be only one solution to NIH syndrom, ... a shooting squad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110831/d79c0ced/attachment.asc>