[FFmpeg-devel] [PATCH] lavfi: unify asink_buffer and vsink_buffer API

[Stefano Sabatini]

On date Saturday 2011-08-27 01:19:36 +0200, Michael Niedermayer encoded:
> On Thu, Aug 25, 2011 at 03:09:45PM +0200, Stefano Sabatini wrote:
> > On date Saturday 2011-08-20 19:44:59 +0200, Stefano Sabatini encoded:
> > > More generic, less code duplication.
> > > ---
> > >  avconv.c                    |    5 +-
> > >  ffmpeg.c                    |    5 +-
> > >  ffplay.c                    |    5 +-
> > >  libavdevice/lavfi.c         |   11 ++--
> > >  libavfilter/Makefile        |    2 +-
> > >  libavfilter/asink_abuffer.c |   97 ------------------------------
> > >  libavfilter/asink_abuffer.h |   47 ---------------
> > >  libavfilter/vsink_buffer.c  |  139 ++++++++++++++++++++++++++++++++++---------
> > >  libavfilter/vsink_buffer.h  |   38 +++++++++---
> > >  9 files changed, 155 insertions(+), 194 deletions(-)
> > >  delete mode 100644 libavfilter/asink_abuffer.c
> > >  delete mode 100644 libavfilter/asink_abuffer.h
> > 
> > Breaks ABI, adding a backward compatibility layers seems no easy
> > (unless we add another buffer2 sink), so I suggest to bump major and
> > get done with it.
> 
> ok but i suggest we use this opertunity to make the code not require
> ABI bumps on extensions where its avoidable
> so we dont need to bump weekly

Please check attachment.

Bikeshed:
av_sink_buffer_get_buffer_ref
or
avfilter_sink_buffer_get_buffer_ref
?

If this is fine I'm also going to rename:
vsink_buffer.{hc} -> sink_buffer.{hc}

in a separate commit.

I'm also attaching the lavfi indev audio support patch for reference.
-- 
FFmpeg = Fiendish Fast Mega Patchable Elastic Goblin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavfi-unify-asink_buffer-and-vsink_buffer-API.patch
Type: text/x-diff
Size: 29198 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110827/c31f55ce/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-lavdev-lavfi-add-audio-filtering-support.patch
Type: text/x-diff
Size: 7438 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110827/c31f55ce/attachment-0001.bin>