[FFmpeg-devel] [ffmpeg-devel] [PATCH 2/4] lavfi: add asink_abuffer - audio sink buffer filter

[Mina Nagy Zaki]

On Tue, Aug 02, 2011 at 12:33:35AM +0200, Stefano Sabatini wrote:
> On date Monday 2011-08-01 12:35:20 +0300, Mina Nagy Zaki encoded:
[...]

Fixed.

> 
> > + * @param samplesref pointer to an AVFilterBufferRef* to put buffer
>                                                          ^^^^^^^^^^^^^
> typo?
> 
> nit++: maybe you can entirely skip the @param, but it would generate a
> doxygen warning, so do as you prefer.
> 

Removed. Also consistent with video sink.

> > + * @param flags unused
> > + * @return >= 0 in case of success, a negative AVERROR code in case of failure
> > + */
> > +int av_asink_abuffer_get_audio_buffer_ref(AVFilterContext *abuffersink,
> > +                                          AVFilterBufferRef **samplesref,
> > +                                          int av_unused flags);
> > +
> > +#endif /* AVFILTER_ASINK_ABUFFER_H */
> 
> Looks fine otherwise.
> 
> Possible todos includes: support for a peek flag like in the video
> sink, support for multiple frames caching (depends on av_fifo_peek2(),
> can't yet be implemented).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-lavfi-add-asink_abuffer-audio-sink-buffer-filter.patch
Type: text/x-diff
Size: 7603 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110802/f4448211/attachment.bin>