[FFmpeg-devel] [PATCH] Fix colors for DVD subtitles
baptiste.coudurier at gmail.com
Sat Apr 23 21:46:09 CEST 2011
On 4/23/11 8:41 AM, Reimar Döffinger wrote:
> On Thu, Apr 21, 2011 at 11:25:33AM +0200, Alexandre Colucci wrote:
>> This patch fixes the DVD subtitle colors/alpha info. See screenshots for before and after the patch.
> I don't think that is correct.
> First, the yellow colour was chosen on purpose, and a lot of DVDs
> use yellow but in principle one is as good as the other.
> Secondly the function is called guess_palette for a reason:
> It is a guess. It will be wrong. But so will yours.
> Unless you have very good data to believe that yours actually
> works better significantly more often I don't think there's a
> good reason to change the code.
Well, I think yellow is ugly personally, I like the patch if it works in
a lot of cases.
Key fingerprint 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer http://www.ffmpeg.org
More information about the ffmpeg-devel