[FFmpeg-devel] [PATCH] libvpx: deadline & profile support

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Mon, Jul 12, 2010 at 10:40:41PM +0200, Michael Niedermayer wrote:
>> On Mon, Jul 12, 2010 at 04:23:04PM -0400, James Zern wrote:
>> > On Sun, Jul 11, 2010 at 08:58, Michael Niedermayer <michaelni at gmx.at> wrote:
>> > >> + ? ?switch (FFABS(avctx->level) / 100) {
>> > >> + ? ?case 1:
>> > >> + ? ? ? ?ctx->deadline = VPX_DL_BEST_QUALITY;
>> > >> + ? ? ? ?break;
>> > >> + ? ?case 2:
>> > >> + ? ?default:
>> > >> + ? ? ? ?ctx->deadline = VPX_DL_GOOD_QUALITY;
>> > >> + ? ? ? ?break;
>> > >> + ? ?case 3:
>> > >> + ? ? ? ?ctx->deadline = VPX_DL_REALTIME;
>> > >> + ? ? ? ?break;
>> > >> + ? ?}
>> > >> + ? ?av_log(avctx, AV_LOG_DEBUG, "Using deadline: %lu\n", ctx->deadline);
>> > >
>> > > avctx->level and ctx->deadline seem to differ in semantics, so iam not
>> > > in favor of this
>> > 
>> > That's fair, I didn't see a great mapping for these though. Would they
>> > warrant new parameters? Maybe a flags2 for error resilience?
>> 
>> once we support codec specific options this should be easier and cleaner
>> possible.
>
> codec specific options are supported now

They are?

-- 
M?ns Rullg?rd
mans at mansr.com