[FFmpeg-devel] [PATCH] FLAC parser

[Justin Ruggles]

Michael Chinen wrote:

> Hi,
> 
> On Mon, Sep 27, 2010 at 1:32 AM, Felipe Contreras
> <felipe.contreras at gmail.com> wrote:
>> 2010/9/26 M?ns Rullg?rd <mans at mansr.com>:
>>> Felipe Contreras <felipe.contreras at gmail.com> writes:
>>>
>>>> On Sun, Sep 26, 2010 at 1:58 PM, Michael Chinen <mchinen at gmail.com> wrote:
>>>>> On Sun, Sep 26, 2010 at 2:00 AM, Felipe Contreras
>>>>> [...]
>>>>>> Ah, I needed CONFIG_FLAC_PARSER.
>>>>> I would like to test this.  I am running configure without any mention
>>>>> of the parser.  How can I get it to go without CONFIG_FLAC_PARSER?
>>>> I guess --disable-parser=flac
>>>>
>>>>>> Since now the decoder doesn't work without the parser, wouldn't a
>>>>>> dependency should somehow be specified?
>>>>> Is this dependency undesirable?  I can look into getting both cases to
>>>>> work if so.
>>>> I don't know, but with your patches this stopped working:
>>>> ./configure --disable-everything --enable-decoder='flac'
>>>> --enable-demuxer='ogg,flac' --enable-protocol=file
>>>> --enable-encoder='pcm_s16le' --enable-muxer='wav'
>>>>
>>>> ffmpeg -i test.flac test.wav
>>> The demuxer probably needs the parser to find frame boundaries.  Can
>>> it play flac in ogg (where ogg provides the framing)?
>> I haven't tried this yet, but at least it doesn't seem to work with my
>> gst-av[1] stuff, so I think the problem is in the decoder itself.
> 
> Any ogg related thing is definitely not supported in this
> parser/decoder (nor in the previous flacdec.c).
> flac in ogg is .ogg file right? - should it be handled by this parser/decoder?
> 
> The patch isn't ready quite yet, but I'm working on it.

I can confirm that Ogg/FLAC doesn't work when you disable the parser,
but it does work when you enable the parser.  This is weird because the
Ogg demuxer doesn't even set st->need_parsing.  Plus, like Mans said,
Ogg shouldn't need to use the parser.  If Michael doesn't already have
it figured out, I'll see if I can find the problem this afternoon after
work.

-Justin