[FFmpeg-devel] [PATCH] Use SLIBSUF instead of .so in vf_frei0r

[Víctor Paesa]

Hi,

On Sun, Sep 26, 2010 at 22:36, M?ns Rullg?rd wrote:
> V?ctor Paesa writes:
>
>> Hi,
>>
>> Patch attached to use a more generic dynamic library suffix.
>>
>> Regards,
>> V?ctor
>>
>> Index: configure
>> ===================================================================
>> --- configure (revision 25211)
>> +++ configure (working copy)
>> @@ -3214,6 +3214,7 @@
>> ?#define ASMALIGN(ZEROBITS) ".p2align " #ZEROBITS "\\n\\t"
>> ?#define EXTERN_PREFIX "${extern_prefix}"
>> ?#define EXTERN_ASM ${extern_prefix}
>> +#define SLIBSUF "$SLIBSUF"
>> ?EOF
>
> OK
>
>> ?test -n "$malloc_prefix" &&
>> Index: libavfilter/vf_frei0r.c
>> ===================================================================
>> --- libavfilter/vf_frei0r.c ? (revision 25211)
>> +++ libavfilter/vf_frei0r.c ? (working copy)
>> @@ -191,7 +191,7 @@
>> ?{
>> ? ? ?char path[1024];
>>
>> - ? ?snprintf(path, sizeof(path), "%s%s.so", prefix, name);
>> + ? ?snprintf(path, sizeof(path), "%s%s%s", prefix, name, SLIBSUF);
>> ? ? ?av_log(ctx, AV_LOG_DEBUG, "Looking for frei0r effect in '%s'\n", path);
>> ? ? ?return dlopen(path, RTLD_NOW|RTLD_LOCAL);
>> ?}
>
> Is this correct on macos too? ?That is, are the plugins named *.dylib there?

Yes: the frei0r maillist shows a "../../lib/frei0r-1/distort0r.dylib"
in a darwin context.
http://blog.gmane.org/gmane.comp.video.frei0r.devel/month=20050701

So at least one person uses .dylib plugins.

frei0r ships with two build environments: autotools and CMake.

autotools has a hardcoded ".so" in src/Makefile.am (I raised ticket
http://www.piksel.no/projects/frei0r/ticket/31)
so plugins not ending in .so will not be installed.

There is no ".so" hardcode in the CMake files, hence I believe
that will produce .dylib plugins on MacOS.

But that's my untested guess.
All in all, if no MacOS expert complains before, I'll apply the patch
in a couple of days.

Regards,
V?ctor