[FFmpeg-devel] [PATCH] Add asrc abuffer - audio source buffer for lavfi

[Justin Ruggles]

S.N. Hemanth Meenakshisundaram wrote:

>  Added documentation to asrc-abuffer.h header.
> 
> Changed init to accept strtol base 0. (Corresponding change in ffmpeg.c
> follows)
> 
> To answer the rest of Justin's questions:
> 
> 1. CH_LAYOUT_STEREO has value 0x3 which is less than CH_LAYOUT_MONO
> (0x4). Hence it will be accepted.
> 
> The front left and front right channels are by themselves not valid
> channel layouts in the channel layout table in avcodec.h
> 
> Although we can process audio buffers with such layouts, wouldn't it be
> better to add those layouts to the list of valid layouts than handle
> them individually here?
> 
> This is also the problem with allowing the user to specify strings like
> CH_FRONT_LEFT|CH_FRONT_RIGHT etc. We would then need to check if the
> layout is valid. I can change it if doing the check is preferable to the
> current method of using the strings in audioconvert.c for the channel
> layouts.

What list are you talking about?  All channel layouts are valid.

-Justin