[FFmpeg-devel] [PATCH2/3] asfdec.c doesn't detect aspect ratio properly in some case

[Michael Niedermayer]

On Wed, Sep 22, 2010 at 12:27:19PM -0700, Richard Buteau wrote:
> 
> 
> > -----Original Message-----
> > From: ffmpeg-devel-bounces at mplayerhq.hu [mailto:ffmpeg-devel-
> > bounces at mplayerhq.hu] On Behalf Of Michael Niedermayer
> > Sent: Wednesday, September 22, 2010 2:15 PM
> > To: FFmpeg development discussions and patches
> > Subject: Re: [FFmpeg-devel] [PATCH2/3] asfdec.cdoesn't
> > detectaspectratioproperly in some case
> > 
> > On Wed, Sep 22, 2010 at 08:26:40AM -0700, Richard Buteau wrote:
> > >
> > >
> > > > -----Original Message-----
> > > > From: ffmpeg-devel-bounces at mplayerhq.hu [mailto:ffmpeg-devel-
> > > > bounces at mplayerhq.hu] On Behalf Of Carl Eugen Hoyos
> > > > Sent: Wednesday, September 22, 2010 10:10 AM
> > > > To: ffmpeg-devel at mplayerhq.hu
> > > > Subject: Re: [FFmpeg-devel] [PATCH2/3] asfdec.c doesn't
> > > > detectaspectratioproperly in some case
> > > >
> > > > Richard Buteau <rbuteau <at> rgbnetworks.com> writes:
> > > >
> > > > [...]
> > > >
> > > > > +    AVRational dar_ech;
> > > > >      uint32_t bitrate[128];
> > > > >
> > > > >      memset(dar, 0, sizeof(dar));
> > > > > +    dar_ech.den=0;
> > > > > +    dar_ech.num=0;
> > > done
> > > >
> > > > I think you can merge declaration and initialisation here.
> > > >
> > > > [...]
> > > >
> > > > > -                    get_tag(s, name, value_type, value_len);
> > > >
> > > > > +                        get_tag(s, name, value_type,
> value_len);
> > > >
> > > > While it's only one line, I still believe the patch is more
> > readable
> > > if
> > > > you do
> > > > not re-indent it.
> > > done
> > > >
> > > > Carl Eugen
> > > >
> > > > _______________________________________________
> > > > ffmpeg-devel mailing list
> > > > ffmpeg-devel at mplayerhq.hu
> > > > https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
> > 
> > Content-Description: asfAR.patch_updatedv3.txt
> > > diff -uNr -x .svn -x '*.d' ffmpeg/libavformat/asfdec.c
> > ffmpeg.asfAR/libavformat/asfdec.c
> > > --- ffmpeg/libavformat/asfdec.c	2010-09-14 13:04:36.000000000
> -0500
> > > +++ ffmpeg.asfAR/libavformat/asfdec.c	2010-09-22
> 10:19:20.000000000
> > -0500
> > > @@ -191,6 +191,7 @@
> > >      int size, i;
> > >      int64_t gsize;
> > >      AVRational dar[128];
> > > +    AVRational dar_ech={0,0};
> > >      uint32_t bitrate[128];
> > >
> > >      memset(dar, 0, sizeof(dar));
> > > @@ -467,6 +468,15 @@
> > >                      value_len  = get_le16(pb);
> > >                      if (!value_type && value_len%2)
> > >                          value_len += 1;
> > > +                    /**
> > > +                     * My sample has that stream set to 0 that mean
> > the container.
> > > +                     * Asf stream count start at 1. I am using 0 to
> > > + the container value since it's unused
> > 
> > that comment no longer matches the code
> I took it out.
> > 
> > 
> > [...]
> > --
> > Michael     GnuPG fingerprint:
> 9FF2128B147EF6730BADF133611EC787040B0FAB
> > 
> > Freedom in capitalist society always remains about the same as it was
> > in ancient Greek republics: Freedom for slave owners. -- Vladimir
> Lenin

Content-Description: asfAR.patch_updatedv4.txt
> diff -uNr -x .svn -x '*.d' ffmpeg/libavformat/asfdec.c ffmpeg.asfAR/libavformat/asfdec.c

should be ok if tested

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100923/f7a051c3/attachment.pgp>