[FFmpeg-devel] [PATCH 4/4] Make the crop filter accept parametric expressions.

[Stefano Sabatini]

On date Tuesday 2010-09-14 18:01:00 +0200, Michael Niedermayer encoded:
> On Tue, Sep 14, 2010 at 05:48:16PM +0200, Stefano Sabatini wrote:
> > On date Tuesday 2010-09-14 16:58:11 +0200, Michael Niedermayer encoded:
> > > On Tue, Sep 14, 2010 at 12:30:46PM +0200, Stefano Sabatini wrote:
> > [...]
> > > > diff --git a/libavfilter/vf_crop.c b/libavfilter/vf_crop.c
> > > > index 4f8a382..e7d798a 100644
> > > > --- a/libavfilter/vf_crop.c
> > > > +++ b/libavfilter/vf_crop.c
> > > > @@ -24,8 +24,42 @@
> > > >   */
> > > >  
> > > >  #include "avfilter.h"
> > > > +#include "libavutil/eval.h"
> > > > +#include "libavutil/avstring.h"
> > > >  #include "libavcore/imgutils.h"
> > > >  
> > > > +static const char *var_names[] = {
> > > > +    "E",
> > > > +    "PHI",
> > > > +    "PI",
> > > 
> > > > +    "w",      ///< width  of the input video
> > > > +    "h",      ///< height of the input video
> > > > +    "crop_w", ///< width  of the cropped video
> > > > +    "crop_h", ///< height of the cropped video
> > > 
> > > i think these are poorly named as every filter (not just crop) has in and
> > > out width/height and we should be consistent amongth all filters
> > > iw/ow could be in/out with
> > 
> > Are in_w/h out_w/h OK?
> 
> no, they are  too long
> 
> > 
> > I don't like to interpret enigmatic acronyms.
> 
> there are like 5 variables only ...
> feel free to add longer duplicated ones

Done, now the filter accepts both (in|out)X and (i|o)X.

Regards.
-- 
FFmpeg = Fundamental and Faithful Multimedia Ponderous Erroneous God