[FFmpeg-devel] [PATCH] yadif port to libavfitler

[Ronald S. Bultje]

Hi,

On Thu, Sep 9, 2010 at 6:36 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Thu, Sep 09, 2010 at 06:30:47PM -0400, Ronald S. Bultje wrote:
>> On Wed, Sep 8, 2010 at 11:50 AM, Stefano Sabatini
>> <stefano.sabatini-lala at poste.it> wrote:
>> > Updated again. Documentation for the second param should be extended,
>> > (Mplayer docs is outdated as well), also maybe ASM code should be
>> > placed in /ARCH dirs.
>> [..]
>> > + ? ? ? ? ? ? ? ?yadif->filter_line(ctx, dst, prev, cur, next, w, refs, parity ^ tff);
>>
>> Since the asm code is called as a function pointer, not inlined, I'd
>> like to "kindly suggest" that the code be ported to yasm before it is
>> committed.
>
> the question remains why?
> the bug can be fixed with a single letter change (that be s/g/r/ likely)
> rewriting code takes time and risks introducing bugs and requires more time
> reviewing, our resources arent all that great for these 1000% bikeshed
> rewrites

That's why I wrote "kindly suggest", not "insist and inhibit". If
committed as-is, I'll port it myself some day (please add a fate
test!).

Ronald