[FFmpeg-devel] [RFC] AAC bsf and rtp/rtsp

[Michael Niedermayer]

On Thu, Sep 09, 2010 at 04:44:23PM +0200, Luca Barbato wrote:
> On 9/9/10 4:19 PM, Michael Niedermayer wrote:
>> On Thu, Sep 09, 2010 at 04:16:41PM +0200, Luca Barbato wrote:
>>> On 9/9/10 3:16 PM, Michael Niedermayer wrote:
>>>> On Thu, Sep 09, 2010 at 03:08:33PM +0200, Luca Barbato wrote:
>>>>> On 9/8/10 6:28 PM, Ronald S. Bultje wrote:
>>>>>> That nice solution isn't completely impossible to implement, is it?
>>>>>
>>>>> The simplest thing is passing the bsf in the context, anybody against that?
>>>>
>>>> until the problem has been explained i wont accept any solution to code i
>>>> maintain
>>>> the initial mail of this thread is so terse and full of grammer errors i
>>>> have no idea at all what you talk about
>>>
>>> looks like that a stray "is" was left while I was rewriting the
>>> sentence, sorry.
>>>
>>> Anyway:
>>>
>>> - in order to produce the sdp lines for aac we need the aac extradata.
>>> - adts stream do not provide extradata
>>> - the bsf filter to reformat aac to asc would provide the extradata.
>>> - because how bsf works in the extradata would be updated once it starts
>>> to output packets.
>>>
>>> ffmpeg -i s.aac -acodec copy -absf aac_adtstoasc -f rtp rtp://l:port
>>>
>>> Won't work even if it should.
>>>
>>> To fix it the simplest way would be having the av_find_stream_info aware
>>> of the bsf in use so they will be called at the same level of the
>>> parsers, giving a consistent result.
>>
>> the AVCodecParser.split() function exists to extract extradata from the
>> packets at av_find_stream_info() level
>
> So you'd suggest to use the extradata extraction logic there  
> independently from the bsf presence?

yes

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100909/187fe1a3/attachment.pgp>