[FFmpeg-devel] [PATCH] rgb2rgb: build SSE2 codepath

[Michael Niedermayer]

On Tue, Sep 07, 2010 at 09:51:29PM -0300, Ramiro Polla wrote:
> On Tue, Sep 7, 2010 at 4:24 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Mon, Sep 06, 2010 at 02:43:29AM -0300, Ramiro Polla wrote:
> >> $subj
> >
> >> ?options.c | ? ?1 +
> >> ?rgb2rgb.c | ? 13 ++++++++++++-
> >> ?swscale.h | ? ?1 +
> >> ?3 files changed, 14 insertions(+), 1 deletion(-)
> >> 795c1e882847320534a2047cb3df9da580023bb9 ?0004-rgb2rgb-build-SSE2-codepath.patch
> >> From a9ad8c14ae6869b2fa2510f53f0a1dcf196be8ba Mon Sep 17 00:00:00 2001
> >> From: Ramiro Polla <ramiro.polla at gmail.com>
> >> Date: Mon, 6 Sep 2010 02:40:03 -0300
> >> Subject: [PATCH 4/5] rgb2rgb: build SSE2 codepath
> >>
> >> ---
> >> ?options.c | ? ?1 +
> >> ?rgb2rgb.c | ? 13 ++++++++++++-
> >> ?swscale.h | ? ?1 +
> >> ?3 files changed, 14 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/options.c b/options.c
> >> index 75564cb..10c077d 100644
> >> --- a/options.c
> >> +++ b/options.c
> >> @@ -49,6 +49,7 @@ static const AVOption options[] = {
> >> ? ? ?{ "accurate_rnd", "accurate rounding", 0, FF_OPT_TYPE_CONST, SWS_ACCURATE_RND, INT_MIN, INT_MAX, VE, "sws_flags" },
> >> ? ? ?{ "mmx", "MMX SIMD acceleration", 0, FF_OPT_TYPE_CONST, SWS_CPU_CAPS_MMX, INT_MIN, INT_MAX, VE, "sws_flags" },
> >> ? ? ?{ "mmx2", "MMX2 SIMD acceleration", 0, FF_OPT_TYPE_CONST, SWS_CPU_CAPS_MMX2, INT_MIN, INT_MAX, VE, "sws_flags" },
> >> + ? ?{ "sse2", "SSE2 SIMD acceleration", 0, FF_OPT_TYPE_CONST, SWS_CPU_CAPS_SSE2, INT_MIN, INT_MAX, VE, "sws_flags" },
> >> ? ? ?{ "3dnow", "3DNOW SIMD acceleration", 0, FF_OPT_TYPE_CONST, SWS_CPU_CAPS_3DNOW, INT_MIN, INT_MAX, VE, "sws_flags" },
> >> ? ? ?{ "altivec", "AltiVec SIMD acceleration", 0, FF_OPT_TYPE_CONST, SWS_CPU_CAPS_ALTIVEC, INT_MIN, INT_MAX, VE, "sws_flags" },
> >> ? ? ?{ "bfin", "Blackfin SIMD acceleration", 0, FF_OPT_TYPE_CONST, SWS_CPU_CAPS_BFIN, INT_MIN, INT_MAX, VE, "sws_flags" },
> >> diff --git a/rgb2rgb.c b/rgb2rgb.c
> >> index f92e165..3eab9d8 100644
> >> --- a/rgb2rgb.c
> >> +++ b/rgb2rgb.c
> >> @@ -175,11 +175,20 @@ DECLARE_ASM_CONST(8, uint64_t, blue_15mask) ?= 0x0000001f0000001fULL;
> >> ?#define RENAME(a) a ## _MMX2
> >> ?#include "rgb2rgb_template.c"
> >>
> >> +//SSE2 versions
> >> +#undef RENAME
> >
> >> +#undef HAVE_SSE2
> >
> > shouldnt this be further up ?
> 
> further up where? it's already there:
> //Note: We have C, MMX, MMX2, 3DNOW versions, there is no 3DNOW + MMX2 one.
> //plain C versions
> #undef HAVE_MMX
> #undef HAVE_MMX2
> #undef HAVE_AMD3DNOW
> #undef HAVE_SSE2

ahh ok, missed that

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100908/f37095ee/attachment.pgp>