[FFmpeg-devel] [PATCH] libspeex Speex encoding

[Justin Ruggles]

Reimar D?ffinger wrote:

> On Tue, Sep 07, 2010 at 06:22:58AM -0400, Justin Ruggles wrote:
>> Michael Niedermayer wrote:
>>
>>> On Tue, Jun 22, 2010 at 10:31:23AM +0200, Nicolas George wrote:
>>>> Le quartidi 4 brumaire, an CCXVIII, Justin Ruggles a ?crit :
>>>>> This patch combines parts of my previous libspeex encoding patch with
>>>>> parts of the one sent by Art Clarke.
>>>> <snip>
>>>>
>>>> Excuse-me, but I wonder what has become of this patch.
>>> waiting for a new revission that considers all comments
>>> dunno if there are open questions left
>> I have an updated patch ready.  Well, 2 patches.  It needs an
>> audio_frames_per_packet field added to AVCodecContext.
> 
> Are you sure this will work? If it's possible to have a speex
> stream where this value changes, having it in AVCodecContext
> will result in the same race condition as the PaletteControl
> stuff, and thus be just wrong.
> If it doesn't change it might be nicer to munge it into extradata
> so it will work find with stream copy into e.g. AVI, nut, ...

It should not change.  It is in the global header, and in-band signals
do not allow it to be changed.  Even in the final packet, dummy frames
are used at the end to make it constant.

For stream copy it really isn't necessary.  And for Speex it is already
in the extradata (except in FLV where there is no Speex header, but that
is a different issue).

The real need is for encoding.  We need to give the user the option to
tell the encoder the number of frames per packet to use.

-Justin