[FFmpeg-devel] [PATCH ]FLV Metadata

[Tomás Touceda]

2010/9/3 Anton Khirnov <anton at khirnov.net>:
>
>> diff -Naur ffmpeg-9999.old/libavformat/flvenc.c ffmpeg-9999/libavformat/flvenc.c
>> --- ffmpeg-9999.old/libavformat/flvenc.c ? ? ?2010-08-07 10:21:58.000000000 -0300
>> +++ ffmpeg-9999/libavformat/flvenc.c ?2010-09-02 17:19:21.000000000 -0300
>> @@ -22,6 +22,7 @@
>> ?#include "flv.h"
>> ?#include "internal.h"
>> ?#include "avc.h"
>> +#include "metadata.h"
>>
>> ?#undef NDEBUG
>> ?#include <assert.h>
>> @@ -257,6 +258,12 @@
>> ? ? ? ? ?put_amf_double(pb, audio_enc->codec_tag);
>> ? ? ?}
>>
>> + ? ?while ((tag = av_metadata_get(m, "", tag, AV_METADATA_IGNORE_SUFFIX))) {
>> + ? ? ? ?put_amf_string(pb, tag.key);
>> + ? ? ? ?put_byte(pb, AMF_DATA_TYPE_STRING);
>> + ? ? ? ?put_amf_string(pb, tag.value);
>> + ? ?}
>> +
>> ? ? ?put_amf_string(pb, "filesize");
>> ? ? ?flv->filesize_offset= url_ftell(pb);
>> ? ? ?put_amf_double(pb, 0); // delayed write
>
> This doesn't build -- 'tag' and 'm' are not declared, besides
> av_metadata_get returns a pointer, so tag.key and tag.value are wrong.
> Why did you change all this? It was correct in your last patch.

Uf... sorry, I must got the patches mixed up... When I get home I'll
send the right one...

>
> Anton Khirnov
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
>
> iEYEARECAAYFAkyBBx4ACgkQtQoSQcBnB6swKgCeIOX1dUPGcwp5guDtqDiaYWNP
> xLkAn2YsJnul/WUh/kRRyowFMQq4Cpu4
> =hPm8
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>