[FFmpeg-devel] [PATCH ]FLV Metadata

[Michael Niedermayer]

On Thu, Sep 02, 2010 at 05:20:58PM -0300, Tom?s Touceda wrote:
> 2010/8/14 Aurelien Jacobs <aurel at gnuage.org>:
> [snip]
> >
> >> diff -Naur ffmpeg-9999.old/libavformat/flvenc.c ffmpeg-9999/libavformat/flvenc.c
> >> --- ffmpeg-9999.old/libavformat/flvenc.c ? ? ?2010-08-12 23:55:16.000000000 -0300
> >> +++ ffmpeg-9999/libavformat/flvenc.c ?2010-08-12 23:56:15.000000000 -0300
> >> @@ -22,6 +22,7 @@
> >> ?#include "flv.h"
> >> ?#include "internal.h"
> >> ?#include "avc.h"
> >> +#include "metadata.h"
> >>
> >> ?#undef NDEBUG
> >> ?#include <assert.h>
> >> @@ -257,6 +258,15 @@
> >> ? ? ? ? ?put_amf_double(pb, audio_enc->codec_tag);
> >> ? ? ?}
> >>
> >> + ? ?if(s->metadata) {
> >
> > This test is useless. Just remove it.
> >
> >> + ? ? ? ?AVMetadataTag *tag = NULL;
> >> + ? ? ? ?while((tag = av_metadata_get(s->metadata, "", tag, AV_METADATA_IGNORE_SUFFIX))) {
> >
> > Add a space between while and (.
> >
> 
> Done. Any other changes I should make?
> 
> Cheers,
> Tomas
> 
> > Aurel
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at mplayerhq.hu
> > https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
> >

>  flvenc.c |    7 +++++++
>  1 file changed, 7 insertions(+)
> 3f5d77f6c797eae4ab87da7795e756a1b1773dc7  ffmpeg-metadata.patch

might be ok if tested

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100903/693a1988/attachment.pgp>