[FFmpeg-devel] [PATCH] fix h264_deblock_sse2.asm segfaults on clang/x86-32

[Ronald S. Bultje]

Hi Michael,

On Thu, Sep 2, 2010 at 10:28 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Thu, Sep 02, 2010 at 08:15:32AM -0400, Ronald S. Bultje wrote:
>> On Thu, Sep 2, 2010 at 4:44 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> > I dont mind if people disable optimized code for clang or add such
>> > workarounds conditional on the compiler being clang.
>>
>> Well, the "problem" is that the compiler isn't clang. The compiler is
>> yasm, the calling code is clang-compiled. (Same bug likely applies to
>> old icc and some of the other "exotic" compilers on fate that fail the
>> h264 tests.)
>>
>> If we add a config.asm that is a yasmified config.h, and have both
>> define the C compiler being used to conditionally enable this
>> "hack"/"fix" in deblock asm, would that be acceptable to you?
>
> yes, of course

Mans, do you think it's possible to do this? I'm all in favour of a config.asm.

Ronald