[FFmpeg-devel] [PATCH] move H264 mmx2 (bi)weight functions to yasm

Ronald S. Bultje rsbultje
Thu Sep 2 12:44:13 CEST 2010


Hi,

On Wed, Sep 1, 2010 at 3:06 PM, Jason Garrett-Glaser
<darkshikari at gmail.com> wrote:
> On Wed, Sep 1, 2010 at 11:01 AM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
>> On Wed, Sep 1, 2010 at 11:56 AM, Aurelien Jacobs <aurel at gnuage.org> wrote:
>>> On Wed, Sep 01, 2010 at 09:58:51AM -0400, Ronald S. Bultje wrote:
>>>> --- ffmpeg-svn.orig/libavcodec/x86/Makefile ? 2010-09-01 09:21:59.000000000 -0400
>>>> +++ ffmpeg-svn/libavcodec/x86/Makefile ? ? ? ?2010-09-01 09:22:30.000000000 -0400
>>>> @@ -10,7 +10,7 @@
>>>>
>>>> ?MMX-OBJS-$(CONFIG_H264DSP) ? ? ? ? ? ? += x86/h264dsp_mmx.o
>>>> ?YASM-OBJS-$(CONFIG_H264DSP) ? ? ? ? ? ?+= x86/h264_deblock_sse2.o ? ? ? \
>>>> - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?x86/h264_weight_sse2.o ? ? ? ?\
>>>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?x86/h264_weight.o ? ? ? ?\
>>>
>>> Alignment...
>>
>> Fixed.
>>
>> Jason complained I didn't integrate the mmx2 and sse2 ones (which is
>> why yasm is so awesome), and also suggested I write sse2/ssse3
>> versions for the non-square (8x16/16x8/8x4) ones. attached patch tries
>> to do all that (Jason pretty bluntly said he'd refuse a patch that
>> doesn't do this all at once).
>
> No, I said I'd refuse a patch that removed the SSE, which yours
> *appeared* to be because the diff was wonky. ?But it would be nice to
> merge them too ;)

Jason said "OK" on IRC right after this, so applied.

Ronald



More information about the ffmpeg-devel mailing list