[FFmpeg-devel] [PATCH] put ff_ prefix on put/avg functions used outside dsputil_mmx.c

Michael Niedermayer michaelni
Thu Sep 2 10:28:35 CEST 2010


On Wed, Sep 01, 2010 at 10:28:14PM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Wed, Sep 1, 2010 at 9:55 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Thu, Aug 26, 2010 at 05:19:21PM -0400, Ronald S. Bultje wrote:
> >> Hi,
> >>
> >> $subj.
> >>
> >> Ronald
> >
> >> ?cavsdsp_mmx.c ? ? | ? ?2 +-
> >> ?dsputil_mmx.c ? ? | ? 28 ++++++++++++++--------------
> >> ?dsputil_mmx.h ? ? | ? ?6 +++---
> >> ?h264dsp_mmx.c ? ? | ? ?2 +-
> >> ?idct_sse2_xvid.c ?| ? ?4 ++--
> >> ?simple_idct_mmx.c | ? ?4 ++--
> >> ?vp3dsp_sse2.c ? ? | ? ?4 ++--
> >> ?7 files changed, 25 insertions(+), 25 deletions(-)
> >> 8c2db813fe894466f5bdf1bfb947b4e8fb5ad75e ?put_ff_prefix_on_asm_funcs.patch
> >
> > adding ff_ to non static functions that cannot be made static and arent part of
> > public api should be ok
> 
> Thanks, I think this was applied already (and yeah they're non-static
> and used all around in libavcodec/x86/*.c).

if something is applied the patch on the ML should be replied to with a
"applied"

So that every patch has a rejected, looks ok, a review or a applied as reply
that way everyone can keep track of things easily

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is not what we do, but why we do it that matters.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100902/284626d1/attachment.pgp>



More information about the ffmpeg-devel mailing list