[FFmpeg-devel] [PATCH] fix h264_deblock_sse2.asm segfaults on clang/x86-32

[Måns Rullgård]

Carl Eugen Hoyos <cehoyos at ag.or.at> writes:

> Hi!
>
> Ronald S. Bultje <rsbultje <at> gmail.com> writes:
>
>> on fate/clang/freebsd/x86-32 [1], all h264 tests fail with a sigbus.
>> There's some alignment issues in the sse2 asm. The asm appears to
>> assume that the caller function guarantees a certain alignment, which
>> is (IMO) not necessarily true. If the function is called directly from
>> C, stack can have any alignment, depending on the compiler used, so
>> the functions shouldn't assume any specific alignment imo.
>
> Did you look at line 3062 in x86/dsputil_mmx.c (__ICC > 1110) for
> the time you are trying to fix it?

IMO that ifdef should never have been added.

-- 
M?ns Rullg?rd
mans at mansr.com